-
Notifications
You must be signed in to change notification settings - Fork 54
Add modelmesh support #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andrew-Butler <Andrew.Butler@ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drewbutlerbb4 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Tomcli I have a cluster-role and cluster-rolebinding that need to applied on installation. Could you advise on how to get that working? |
|
@drewbutlerbb4 do you have the command/yaml for the new cluster-role? I can convert them into something kustomize can understand and deploy it as part of the deployment. |
|
it would look something like this |
Signed-off-by: Andrew-Butler <Andrew.Butler@ibm.com>
|
Thanks @Tomcli, I have updated accordingly |
Signed-off-by: Andrew-Butler <Andrew.Butler@ibm.com>
|
Okay @Tomcli, I have added that below. Thanks! |
|
/lgtm |
Signed-off-by: Andrew-Butler Andrew.Butler@ibm.com
Rework the inference services asset to work with model-mesh predictors. Includes accessing the predictors with the kubernetes Python sdk, adding cluster role and role binding, and parsing the predictor yaml, and displaying predictor info in UI.