[WIP] Self-referential links in markdown view #264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BluThaitanium The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
BluThaitanium
force-pushed
the
markdown_self_links
branch
from
af05544 to
5b06818
Compare
ckadner
requested review from
ckadner
and removed request for
Tomcli and
yhwang
ckadner
changed the title
Contributor
|
Closing this in favor of PR #306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #261
Updates
npmpackagereact-markdownfor self-referential link functionalityHowever, version 7 breaks the existing MLX UI code. We need to either find an older version that is compatible with MLX and has support for anchor IDs, or, change the MLX UI code to work with the latest version of
react-markdown