Replace /os with /mlx #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
added 2 commits
February 16, 2022 11:23
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
ckadner
suggested changes
Feb 16, 2022
Contributor
ckadner
left a comment
ckadner
left a comment
There was a problem hiding this comment.
Great. Thanks Rafael. I only a small nitpick left :-)
README.md
Outdated
| By default, the MLX UI is available at http://<cluster_node_ip>:30380/mlx/ | ||
|
|
||
| To find the public ip of a node of your cluster | ||
| **If you deployed on a Kubernetes cluster, run the following and look for the ExternalIP column to find the public IP of a node.** |
Contributor
There was a problem hiding this comment.
only Kubernetes should be bold here
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #295