Skip to content

Conversation

@rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Feb 23, 2022

Contributes to #304

I copied the same prerequisites from the Deploy MLX on an existing Kubernetes cluster page, I figured they should provide exactly the same information (e.g. kustomize version)

@mlx-bot mlx-bot requested review from Tomcli and yhwang February 23, 2022 18:56
Rafael Vasquez added 2 commits February 23, 2022 13:58
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Copy link
Contributor

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rafael!

@Tomcli @yhwang -- do you have any objections?

Copy link
Contributor

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mlx-bot
Copy link
Collaborator

mlx-bot commented Feb 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mlx-bot mlx-bot merged commit 3a6351a into claimed-framework:main Feb 25, 2022
@rafvasq rafvasq deleted the openshift-link-fix branch March 14, 2022 15:50
krishnakumar27 pushed a commit to krishnakumar27/mlx that referenced this pull request Mar 30, 2022
…rk#307)

* Copy prereq from vanilla deployment

Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>

* Fix typo

Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>

Co-authored-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Signed-off-by: Krishna Kumar <krishnakumar@ibm.com>
@ckadner ckadner added the Jump-Start Work items for Jump-Start participants label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Jump-Start Work items for Jump-Start participants lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants