Skip to content

Fix startup errors in mlx-ui Docker container (prereg to run on OpenShift) #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlx-bot merged 1 commit into from
Jun 13, 2022
Merged

Fix startup errors in mlx-ui Docker container (prereg to run on OpenShift) #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/origin-mlx/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ RUN cd server && npm install && npm run build

# start app
ENV NODE_ENV=production
CMD ["sh", "-c", "npm run build && mv build/ proc/ && node server/dist/server.js proc/ $PORT"]
CMD ["sh", "-c", "npm run build && node server/dist/server.js build/ $PORT"]
1 change: 0 additions & 1 deletion dashboard/origin-mlx/src/components/Detail/DatasetDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { getUserInfo, hasRole } from '../../lib/util';
import RunView from '../RunView'
import RelatedAssetView from '../RelatedAssetView';
import MarkdownViewer from '../MarkdownViewer';
import LoadingMessage from '../LoadingMessage';
import MetadataView from '../MetadataView';

const isAdmin = hasRole(getUserInfo(), 'admin');
Expand Down
4 changes: 2 additions & 2 deletions dashboard/origin-mlx/src/components/Detail/KFServingDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export default class KFServingDetail extends React.Component<KFServingDetailProp
}
else {
predictorTimestamp = service.metadata.creationTimestamp
predictorStatusIcon = service.status.activeModelState == "Ready"
predictorStatusIcon = service.status.activeModelState === "Ready"
? <CheckCircleIcon className="check-icon"/>
: <ErrorIcon className="error-icon"/>
}
Expand Down Expand Up @@ -414,4 +414,4 @@ export default class KFServingDetail extends React.Component<KFServingDetailProp
</>
)
}
}
}