replacing vocabulary enums with python classes#170
Merged
Conversation
* type classes in `vocabulary` package are not custom python classes * this is a major step to address #163 * this will also be a step forward to clamsproject/mmif#64 as it fixes the issues mentioned in clamsproject/mmif#64 (comment) * NOTE that changes here contain a breaking change; `AnnotationTypes` class no longer has `value` attribute, which was used to get `str` value of a type
Member
Author
|
As stated in the commit msg:
|
This was
linked to
issues
May 25, 2021
Codecov Report
@@ Coverage Diff @@
## develop #170 +/- ##
===========================================
- Coverage 95.96% 95.60% -0.37%
===========================================
Files 6 6
Lines 769 774 +5
===========================================
+ Hits 738 740 +2
- Misses 31 34 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced May 25, 2021
keighrim
added a commit
that referenced
this pull request
May 30, 2021
* bugfix from #170: keys of ContainsDict were casted into str and cause unexpected error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #23 (partially), #64 (partially), and #163.