feat(k8s/cluster): standardize timeout configuration across providers#12
Open
rafeegnash wants to merge 1 commit intok8-gcp-supportfrom
Open
feat(k8s/cluster): standardize timeout configuration across providers#12rafeegnash wants to merge 1 commit intok8-gcp-supportfrom
rafeegnash wants to merge 1 commit intok8-gcp-supportfrom
Conversation
Add standard timeout constants to provider.go and apply them consistently across EKS, GKE, and kubeadm providers. This improves maintainability and ensures consistent behavior across all cluster providers. New constants: - DefaultClusterCreateTimeout (20 min) - DefaultNodeGroupCreateTimeout (15 min) - DefaultNodeGroupDeleteTimeout (10 min) - DefaultSSHConnectTimeout (5 min) - DefaultNodeReadyTimeout (5 min) - DefaultPollInterval (30 sec) - DefaultCommandTimeout (2 min) Files updated: - provider.go: Add timeout constants - eks.go: Use constants in wait functions - gke.go: Use constants in wait functions - kubeadm.go: Use constants for SSH and polling Also adds comprehensive tests for timeout constants and provider types. Refs bgdnvk#72 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New Constants
Files Updated
provider.go: Add timeout constantseks.go: Use constants in wait functionsgke.go: Use constants in wait functionskubeadm.go: Use constants for SSH and pollingTest Plan
Closes bgdnvk#72