refactor(k8s/cluster): extract common provider utilities#14
Open
rafeegnash wants to merge 1 commit intok8-gcp-supportfrom
Open
refactor(k8s/cluster): extract common provider utilities#14rafeegnash wants to merge 1 commit intok8-gcp-supportfrom
rafeegnash wants to merge 1 commit intok8-gcp-supportfrom
Conversation
Extract duplicated getNodesViaKubectl logic into a shared utility function in common.go. This reduces code duplication between EKS and GKE providers by 136 lines. New shared utilities: - GetNodesViaKubectl: Retrieves node info using kubectl - CountReadyNodes: Counts ready nodes in a list - AllNodesReady: Checks if all nodes are ready Both EKS and GKE providers now delegate to the shared implementation. Adds comprehensive tests for the new utility functions. Refs bgdnvk#74 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNodesViaKubectllogic into shared utilityNew Shared Utilities
GetNodesViaKubectlCountReadyNodesAllNodesReadyFiles Changed
common.go: New shared utilities filecommon_test.go: Tests for shared utilitieseks.go: Delegates to shared GetNodesViaKubectlgke.go: Delegates to shared GetNodesViaKubectlTest Plan
Closes bgdnvk#74