Skip to content

docs: remove --cask flag from brew install#115

Closed
yimsk wants to merge 2 commits intomainfrom
develop
Closed

docs: remove --cask flag from brew install#115
yimsk wants to merge 2 commits intomainfrom
develop

Conversation

@yimsk
Copy link
Copy Markdown
Contributor

@yimsk yimsk commented Jan 6, 2026

Summary

  • Remove --cask flag from brew install command
  • Homebrew auto-detects formula vs cask
  • Simpler: brew install clawscli/tap/claws

@claude
Copy link
Copy Markdown

claude Bot commented Jan 6, 2026

PR Review: Remove --cask flag from brew install

Summary

This PR removes the --cask flag from the Homebrew installation command in the README, simplifying it to brew install clawscli/tap/claws.

✅ Positives

  1. Correct Change: Modern Homebrew automatically detects whether a package is a formula or cask, making the --cask flag redundant
  2. Consistency: Aligns with PR docs: simplify homebrew install command #114 which already simplified the brew command by removing the tap step
  3. Documentation Quality: Clearer and simpler instructions for users
  4. Minimal Impact: Documentation-only change with no code modifications

Code Quality & Best Practices

Clean commit message: Follows conventional commits format (docs:) and clearly describes the change

Appropriate scope: Single-line change that's focused and easy to review

No breaking changes: This is a documentation improvement that doesn't affect functionality

Verification

  • The change correctly simplifies the installation command
  • No other documentation files appear to reference the old format
  • The PR description clearly explains the rationale

Potential Considerations

  1. Version Support: While modern Homebrew (3.0+) auto-detects casks, very old versions might not. However, since Homebrew strongly encourages staying up-to-date, this shouldn't be a concern.

  2. Tap Configuration: The command assumes clawscli/tap is properly configured to work without explicit --cask. Based on PR docs: simplify homebrew install command #114, this appears to be working correctly.

Recommendations

Approve and merge: This is a straightforward documentation improvement with no issues found.

Optional follow-up: Consider checking the Homebrew tap repository (clawscli/homebrew-tap) to ensure the cask is properly configured if there are any installation reports after merging.


Overall: LGTM! 🚀 This simplifies the installation experience for users.

@yimsk yimsk closed this Jan 6, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Jan 6, 2026

PR Review

Summary

This PR contains two commits that effectively cancel each other out:

  1. Commit 1 (9d6a903): Removes --cask flag
  2. Commit 2 (737447f): Restores --cask flag

Net change: None - The README remains unchanged from the base branch.

Issues Identified

❌ No actual changes: The PR currently has zero functional impact. The two commits undo each other completely.

Analysis: Should --cask be used?

Based on the commit messages, there seems to be uncertainty about whether --cask is necessary:

Arguments for removing --cask:

  • Modern Homebrew can auto-detect formula vs cask types
  • Simpler command syntax

Arguments for keeping --cask:

  • May be required for disambiguation in this tap
  • Current standard practice in the repository

Recommendation

To move forward, the author should:

  1. Clarify the intent:

    • If --cask should be removed, drop commit 2 and keep only commit 1
    • If --cask should remain, close this PR as it makes no changes
  2. Verify with Homebrew:

    • Test whether brew install clawscli/tap/claws works without --cask
    • Check if the tap defines this as a cask or formula
    • Confirm auto-detection works in practice
  3. Update commit history:

    • Use git rebase -i to clean up the contradictory commits
    • Provide clear rationale in the commit message

Questions for Author

  • What was the reason for restoring the --cask flag in commit 2?
  • Have you tested both installation methods to verify which one works?
  • Is there a specific issue or user report that motivated this change?

Verdict

Cannot approve in current state - The PR needs to be updated with a clear direction and actual changes before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant