Add Aliases using 1080p width in cloudfront, including TAGs in describe#174
Merged
yimsk merged 9 commits intoclawscli:mainfrom Mar 14, 2026
Merged
Add Aliases using 1080p width in cloudfront, including TAGs in describe#174yimsk merged 9 commits intoclawscli:mainfrom
yimsk merged 9 commits intoclawscli:mainfrom
Conversation
Contributor
Author
Code reviewFound 1 issue:
claws/custom/cloudfront/distributions/render.go Lines 191 to 204 in 73631ff The d.Tags(dist.GetTags())🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ring Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Sorry for the slow reply, and thanks for the update! Could you also revert the unrelated changes in: I’d prefer to keep this PR scoped to the CloudFront improvements only. Thanks again! |
…detail views with styling and placeholder support.
Revert non-CloudFront changes introduced alongside the CloudFront aliases/tags feature to keep the PR focused: - detail.go: restore original Tag() styling (Dim + indent) - claude-code-review.yml: restore actions/checkout@v6 - integration-test.yml: restore actions/upload-artifact@v6 - ecs/clusters/render.go: remove unrelated AutoReload flag Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use Field() instead of Tags() for CloudFront detail view so tag labels and values align with the same tabulation as other sections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thanks again for the updates, and sorry for the slow follow-up. Merged now! really nice improvement. Appreciate the contribution! |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 16, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [github:clawscli/claws](https://github.com/clawscli/claws) | patch | `0.15.2` → `0.15.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>clawscli/claws (github:clawscli/claws)</summary> ### [`v0.15.3`](https://github.com/clawscli/claws/releases/tag/v0.15.3) [Compare Source](clawscli/claws@v0.15.2...v0.15.3) #### Changelog - [`73631ff`](clawscli/claws@73631ff) Add Aliases using 1080p width, including TAGs in describe - [`fd13466`](clawscli/claws@fd13466) Merge branch 'main' into dependabot/github\_actions/docker/build-push-action-7 - [`11432c1`](clawscli/claws@11432c1) Merge branch 'main' into dependabot/github\_actions/docker/build-push-action-7 - [`14afff7`](clawscli/claws@14afff7) Merge branch 'main' into dependabot/github\_actions/docker/login-action-4 - [`5247a49`](clawscli/claws@5247a49) Merge branch 'main' into dependabot/github\_actions/docker/login-action-4 - [`3cb49e9`](clawscli/claws@3cb49e9) Merge branch 'main' into dependabot/github\_actions/docker/metadata-action-6 - [`d9f5a92`](clawscli/claws@d9f5a92) Merge branch 'main' into dependabot/github\_actions/docker/setup-buildx-action-4 - [`dfd2cc3`](clawscli/claws@dfd2cc3) Merge branch 'main' into dependabot/github\_actions/docker/setup-buildx-action-4 - [`56da14c`](clawscli/claws@56da14c) Merge branch 'main' into main - [`50fbe43`](clawscli/claws@50fbe43) Merge pull request [#​174](clawscli/claws#174) from paulofloresjunior/main - [`9ae8ff2`](clawscli/claws@9ae8ff2) Merge pull request [#​176](clawscli/claws#176) from clawscli/dependabot/github\_actions/docker/metadata-action-6 - [`cffada4`](clawscli/claws@cffada4) Merge pull request [#​177](clawscli/claws#177) from clawscli/dependabot/github\_actions/docker/setup-buildx-action-4 - [`0e2714b`](clawscli/claws@0e2714b) Merge pull request [#​178](clawscli/claws#178) from clawscli/dependabot/github\_actions/docker/build-push-action-7 - [`d433f49`](clawscli/claws@d433f49) Merge pull request [#​179](clawscli/claws#179) from clawscli/dependabot/github\_actions/docker/login-action-4 - [`3b34798`](clawscli/claws@3b34798) Please provide the file changes to generate a commit message. - [`85ea5fb`](clawscli/claws@85ea5fb) ci: bump docker/build-push-action from 6 to 7 - [`661fe9e`](clawscli/claws@661fe9e) ci: bump docker/login-action from 3 to 4 - [`90628f4`](clawscli/claws@90628f4) ci: bump docker/metadata-action from 5 to 6 - [`056ddc3`](clawscli/claws@056ddc3) ci: bump docker/setup-buildx-action from 3 to 4 - [`c21e727`](clawscli/claws@c21e727) ci: fix actions/checkout version from v6 to v4 - [`dd93b04`](clawscli/claws@dd93b04) feat: Add `DetailBuilder` for consistent and structured rendering of detail views with styling and placeholder support. - [`f1dc370`](clawscli/claws@f1dc370) fix: remove extra indentation from Tag method and refactor tags rendering - [`a031f02`](clawscli/claws@a031f02) fix: render CloudFront tags aligned with other detail sections - [`bb86c91`](clawscli/claws@bb86c91) revert: restore integration-test.yml and ecs/clusters to upstream state - [`c20ebf2`](clawscli/claws@c20ebf2) revert: undo unrelated changes outside CloudFront scope </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My43Ni4zIiwidXBkYXRlZEluVmVyIjoiNDMuNzYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Aliases using 1080p width in cloudfront, including TAGs in describe