Skip to content

Add Aliases using 1080p width in cloudfront, including TAGs in describe#174

Merged
yimsk merged 9 commits intoclawscli:mainfrom
paulofloresjunior:main
Mar 14, 2026
Merged

Add Aliases using 1080p width in cloudfront, including TAGs in describe#174
yimsk merged 9 commits intoclawscli:mainfrom
paulofloresjunior:main

Conversation

@paulofloresjunior
Copy link
Copy Markdown
Contributor

Add Aliases using 1080p width in cloudfront, including TAGs in describe

@paulofloresjunior
Copy link
Copy Markdown
Contributor Author

Code review

Found 1 issue:

  1. Tags are rendered manually in the detail view instead of using the existing DetailBuilder.Tags() method, which already handles sorting and rendering. This duplicates logic and uses d.Field() instead of d.Tag(), resulting in a different visual style than other resources (e.g., cloudformation/stacks uses d.Tags(appaws.TagsToMap(...))).

// Tags (only available after d:describe / Enter)
if tags := dist.GetTags(); len(tags) > 0 {
d.Section("Tags")
keys := make([]string, 0, len(tags))
for k := range tags {
keys = append(keys, k)
}
sort.Strings(keys)
for _, k := range keys {
d.Field(k, tags[k])
}
}

The DetailBuilder.Tags() method already exists in internal/render/detail.go#L135-L152. The block could be replaced with a single call:

d.Tags(dist.GetTags())

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

paulofloresjunior and others added 2 commits March 9, 2026 17:50
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ring

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@yimsk
Copy link
Copy Markdown
Contributor

yimsk commented Mar 10, 2026

Sorry for the slow reply, and thanks for the update!
The CloudFront changes look good to me now.

Could you also revert the unrelated changes in:

internal/render/detail.go
.github/workflows/claude-code-review.yml

I’d prefer to keep this PR scoped to the CloudFront improvements only. Thanks again!

paulofloresjunior and others added 5 commits March 10, 2026 14:00
…detail views with styling and placeholder support.
Revert non-CloudFront changes introduced alongside the CloudFront
aliases/tags feature to keep the PR focused:
- detail.go: restore original Tag() styling (Dim + indent)
- claude-code-review.yml: restore actions/checkout@v6
- integration-test.yml: restore actions/upload-artifact@v6
- ecs/clusters/render.go: remove unrelated AutoReload flag

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use Field() instead of Tags() for CloudFront detail view so tag
labels and values align with the same tabulation as other sections.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@yimsk yimsk merged commit 50fbe43 into clawscli:main Mar 14, 2026
3 of 4 checks passed
@yimsk
Copy link
Copy Markdown
Contributor

yimsk commented Mar 14, 2026

Thanks again for the updates, and sorry for the slow follow-up. Merged now! really nice improvement. Appreciate the contribution!

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 16, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [github:clawscli/claws](https://github.com/clawscli/claws) | patch | `0.15.2` → `0.15.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>clawscli/claws (github:clawscli/claws)</summary>

### [`v0.15.3`](https://github.com/clawscli/claws/releases/tag/v0.15.3)

[Compare Source](clawscli/claws@v0.15.2...v0.15.3)

#### Changelog

- [`73631ff`](clawscli/claws@73631ff) Add Aliases using 1080p width, including TAGs in describe
- [`fd13466`](clawscli/claws@fd13466) Merge branch 'main' into dependabot/github\_actions/docker/build-push-action-7
- [`11432c1`](clawscli/claws@11432c1) Merge branch 'main' into dependabot/github\_actions/docker/build-push-action-7
- [`14afff7`](clawscli/claws@14afff7) Merge branch 'main' into dependabot/github\_actions/docker/login-action-4
- [`5247a49`](clawscli/claws@5247a49) Merge branch 'main' into dependabot/github\_actions/docker/login-action-4
- [`3cb49e9`](clawscli/claws@3cb49e9) Merge branch 'main' into dependabot/github\_actions/docker/metadata-action-6
- [`d9f5a92`](clawscli/claws@d9f5a92) Merge branch 'main' into dependabot/github\_actions/docker/setup-buildx-action-4
- [`dfd2cc3`](clawscli/claws@dfd2cc3) Merge branch 'main' into dependabot/github\_actions/docker/setup-buildx-action-4
- [`56da14c`](clawscli/claws@56da14c) Merge branch 'main' into main
- [`50fbe43`](clawscli/claws@50fbe43) Merge pull request [#&#8203;174](clawscli/claws#174) from paulofloresjunior/main
- [`9ae8ff2`](clawscli/claws@9ae8ff2) Merge pull request [#&#8203;176](clawscli/claws#176) from clawscli/dependabot/github\_actions/docker/metadata-action-6
- [`cffada4`](clawscli/claws@cffada4) Merge pull request [#&#8203;177](clawscli/claws#177) from clawscli/dependabot/github\_actions/docker/setup-buildx-action-4
- [`0e2714b`](clawscli/claws@0e2714b) Merge pull request [#&#8203;178](clawscli/claws#178) from clawscli/dependabot/github\_actions/docker/build-push-action-7
- [`d433f49`](clawscli/claws@d433f49) Merge pull request [#&#8203;179](clawscli/claws#179) from clawscli/dependabot/github\_actions/docker/login-action-4
- [`3b34798`](clawscli/claws@3b34798) Please provide the file changes to generate a commit message.
- [`85ea5fb`](clawscli/claws@85ea5fb) ci: bump docker/build-push-action from 6 to 7
- [`661fe9e`](clawscli/claws@661fe9e) ci: bump docker/login-action from 3 to 4
- [`90628f4`](clawscli/claws@90628f4) ci: bump docker/metadata-action from 5 to 6
- [`056ddc3`](clawscli/claws@056ddc3) ci: bump docker/setup-buildx-action from 3 to 4
- [`c21e727`](clawscli/claws@c21e727) ci: fix actions/checkout version from v6 to v4
- [`dd93b04`](clawscli/claws@dd93b04) feat: Add `DetailBuilder` for consistent and structured rendering of detail views with styling and placeholder support.
- [`f1dc370`](clawscli/claws@f1dc370) fix: remove extra indentation from Tag method and refactor tags rendering
- [`a031f02`](clawscli/claws@a031f02) fix: render CloudFront tags aligned with other detail sections
- [`bb86c91`](clawscli/claws@bb86c91) revert: restore integration-test.yml and ecs/clusters to upstream state
- [`c20ebf2`](clawscli/claws@c20ebf2) revert: undo unrelated changes outside CloudFront scope

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My43Ni4zIiwidXBkYXRlZEluVmVyIjoiNDMuNzYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants