Align naming conventions with AWS CLI

[yimsk]

Summary

• Rename directories/packages to match AWS CLI conventions (kebab-case)
• Fix registry names to align with AWS CLI service names
• Fix DAO error strings and deduplicate client helpers
• Add pseudo-ARN format documentation for Cost Explorer

Closes #65

[claude]

Pull Request Review - PR #71: Align naming conventions with AWS CLI

Summary

This PR successfully refactors directory and package names across the codebase to align with AWS CLI conventions using kebab-case. The changes are systematic and consistent, affecting 238 files with 381 additions and 399 deletions.

---

✅ Strengths

1. Excellent Consistency

• All directory renames follow kebab-case convention systematically
• Error messages in DAO files updated to match new paths
• Import paths updated comprehensively in cmd/claws/imports_custom.go

2. Good Code Quality

• Error message improvements (e.g., new apigateway/http-apis dao vs old camelCase)
• Proper alignment with AWS CLI service names (e.g., cognito-idp, bedrock-agent)
• Zero logic changes - purely structural refactoring

3. Helpful Documentation

• Pseudo-ARN format documentation added for Cost Explorer resources (custom/ce/costs/dao.go:164-166)
• Clear comments explaining why resources don't have real ARNs

4. Code Deduplication

• Removal of duplicate client helper functions in:
  • custom/cfn/stacks/actions.go (lines 59-74)
  • custom/cloudwatch/log-streams/actions.go (lines 58-60)
  • custom/dynamodb/tables/actions.go (lines 77-79)
• Now properly using shared client functions from parent packages

5. CI Improvements

• Added develop branch to CI workflow triggers (.github/workflows/ci.yml)

---

🔍 Observations & Minor Suggestions

1. Service Naming Alignment ✅

The PR correctly aligns service names with AWS CLI conventions:

• costexplorer → ce (matches AWS CLI)
• cognito → cognito-idp (correct service name)
• eventbridge → events (matches AWS CLI)
• sfn → stepfunctions (full service name)
• config → configservice (correct service name)

2. Import Organization

The reorganization of imports in imports_custom.go is good, with logical grouping and alphabetical ordering within groups. The Cost Explorer section was properly moved up to maintain alphabetical order.

3. Error Handling ✅

All error messages in DAO constructors properly updated to reflect new paths, maintaining consistency with the error wrapping pattern used throughout the codebase.

---

🔒 Security Review

• ✅ No security concerns identified
• ✅ No changes to authentication/authorization logic
• ✅ No new external dependencies
• ✅ No changes to data handling or API calls

---

⚡ Performance Considerations

• ✅ Zero performance impact - purely renaming/organizational changes
• ✅ No changes to API calls or data processing logic
• ✅ Client deduplication is a minor positive improvement

---

🧪 Test Coverage

• The PR appears to be primarily structural refactoring
• No test files were modified, which suggests tests reference resources by registration, not import paths (good design)
• Recommendation: Run full test suite to verify all resource registrations work correctly with new names

---

📋 Recommendations

High Priority: None

All changes look good and ready to merge.

Nice to Have:

1. Verify Build: Ensure task gen-imports was run and the generated file is correct (appears to be done)
2. Verify Navigation: Test cross-resource navigation still works after renames
3. Documentation Update: Consider updating any documentation that references old directory names (if any exist)

---

🎯 Final Verdict

✅ APPROVED - Ready to Merge

This is a well-executed refactoring PR that:

• ✅ Follows AWS CLI naming conventions consistently
• ✅ Maintains code quality and improves it (deduplication)
• ✅ Has no security or performance concerns
• ✅ Properly updates all references (imports, error messages, registrations)
• ✅ Adds helpful documentation for pseudo-ARN format

Estimated Risk: Very Low
Type: Refactoring/Cleanup
Breaking Changes: None (internal structure only)

Great work on issue #65! This improves codebase maintainability and aligns with AWS CLI conventions. 🎉

---

📝 Checklist Verification

• ✅ Code quality and best practices - Excellent
• ✅ Potential bugs or issues - None identified
• ✅ Performance considerations - No impact
• ✅ Security concerns - None
• ✅ Test coverage - Should be verified with CI