This repository was archived by the owner on May 6, 2020. It is now read-only.
Fix file descriptor leak tests #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close all KSM related fds that we create in our KSM tests. While these are left open while running the proxy_test.go tests, where detecting leaking file descriptors is relevant, it looks like the open ksm fds get closed by the go runtime in the newer version of Go leading to different before and after file descriptor snapshots in the proxy_test.go tests. Fixes clearcontainers#198 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
This file is opened to check our file descriptor leak detector works correctly. Close it before exiting the test. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Move the defer statements to close fds immediately after they are opened, to make sure they get closed in case of error occuring later on in the program flow. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Contributor
|
LGTM |
|
kubernetes qa-passed 👍 |
Contributor
Author
|
@sameo Please take a look. |
|
Thanks for investigating and fixing this @amshinde. lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close all KSM related fds that we create in our KSM tests.
While these are left open while running the proxy_test.go tests,
where detecting leaking file descriptors is relevant, it looks like
the open ksm fds get closed by the go runtime in the newer version
of Go leading to different before and after file descriptor snapshots in
the proxy_test.go tests.
Fixes #198