This repository was archived by the owner on May 6, 2020. It is now read-only.
logger: Display timezone as offset #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kubernetes qa-passed 👍 |
|
kubernetes qa-passed 👍 |
1 similar comment
|
kubernetes qa-passed 👍 |
Change format of time included in log entries to display the timezone
as an offset.
Example of old format:
time="2017-09-28 13:22:58.965483966 +0100 BST"
Example of new format:
time="2017-09-29T13:22:58.965483966+01:00"
Fixes clearcontainers#650.
Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
log-timezone-as-offset
branch
from
c8aad58 to
99455b6
Compare
|
kubernetes qa-failed 👎 |
|
lgtm
|
Author
|
All tests passed except for coveralls, which is stuck as usual. More oddly than usual, https://coveralls.io/jobs/29948262 claims the unit-test coverage has decreased by 1.8%. However, it's lying and in fact the coveralls report doesn't even list all the files in the repo!?! I've re-run the unit-tests locally on this branch and coverage for Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change format of time included in log entries to display the timezone
as an offset.
Example of old format:
Example of new format:
Fixes #650.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com