-
Notifications
You must be signed in to change notification settings - Fork 18
CI: Show shim log at end of CI run #606
CI: Show shim log at end of CI run #606
Conversation
Display the shim log messages at the end of the CI Run. Fixes clearcontainers#605. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
kubernetes qa-passed 👍 |
grahamwhaley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| echo "Clear Containers Proxy Log:" | ||
| sudo journalctl --no-pager -u cc-proxy | ||
| echo "Clear Containers Shim Log:" | ||
| sudo journalctl --no-pager -t cc-shim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a query/note...
I guess this will show all of the shim log for all of its lifetime - which, my gut tells me we may not want it that contains info from (many) previous runs.... but, then my head tells me that this code is currently specifically run in one-shot VMs, so the only log it should have is from this specific test run...
Just noting like - and considering if in the future we might need to take note of the start time of the test run, and then trim the log to include only data from this run, iyswim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We probably need @chavafg to comment. I personally wipe the journal before running tests locally. Atleast once clearcontainers/shim#90 lands this dump from the beginning-of-time will allow us to atleast link the shim entries with the other pieces.
It's worth noting that once #590 lands, we could be a little cleverer and have the CI call the cc-log-parser tool as described on its README on teardown so that you'd atleast have a time-ordered dump of the run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can wait until #590 lands and see if that makes debugging easier, if not we can start looking other ideas.
|
You have a Fedora CI fail - huge log. I found this, which I suspect may not actually be the problem, but will post anyhow... |
This tells what is doing this test. Fixes clearcontainers#606 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Display the shim log messages at the end of the CI Run.
Fixes #605.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com