This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Serialize store generation, ignore some signals. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clrtrust
Outdated
|
|
||
| lock() { | ||
| # lock should be on the same block device so that we could ln to it | ||
| local lock_path=$(mktemp -p "$(dirname $CLR_TRUST_LOCK_FILE)") |
There was a problem hiding this comment.
It would be slightly simpler I think to say
local lock_path=$(mktemp "${CLR_TRUST_LOCK_FILE}.xxxxxx")
|
|
||
| trap sig_ignore INT HUP TERM | ||
| if is_system_store && ! lock; then | ||
| trap - INT HUP TERM |
There was a problem hiding this comment.
Add an error message, e.g.
1>&2 echo "Error failed to lock $CLR_TRUST_LOCK_FILE"
so the user knows what is happening?
Contributor
Author
There was a problem hiding this comment.
Added on the next line.
In case the store being generated is the system store, ignore HUP, INT and TERM while it's being generated and serialize store write section of the code.
busykai
force-pushed
the
kai/serialize-store-generation
branch
from
4c19184 to
d320b01
Compare
icarus-sparry
approved these changes
Feb 14, 2018
Contributor
Author
|
Thank you, @icarus-sparry! Especially, for the hint on locking! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the store being generated is the system store, ignore HUP, INT and TERM
while it's being generated and serialize store write section of the code.
Fixes #9.
@icarus-sparry, could you please take a look?