Build tensorflow error as "external/grpc/src/core/lib/gpr/log_linux.cc:43:13: error: ambiguating new declaration of 'long int gettid()'"

[liujianjunhq]

When build tensorflow package based on the latest Clear Linux release, below error is gotten.
ERROR: /tmp/bazel/external/grpc/BUILD:507:1: C++ compilation of rule '@grpc//:gpr_base' failed (Exit 1)
external/grpc/src/core/lib/gpr/log_linux.cc:43:13: error: ambiguating new declaration of 'long int gettid()'
43 | static long gettid(void) { return syscall(__NR_gettid); }
| ^~~~~~

[anselmolsm]

Ah, bundled dependencies...
The error is due a conflict with new glibc 2.30's gettid. Clear Linux grpc package has been patched to overcome that build issue, but bazel's bundled one still needs the patch (or patch bazel to use system libraries instead, but it does not seem straight forward due to the build system used..)

[liujianjunhq]

Thanks a lot for your clarification. Do you mean that this issue couldn't be solved until grpc/grpc#18950 is merged?
As tensorflow.spec, grpc package is loaded into /tmp/cache before bazel build. Have you tried to patch the grpc package before loading it into /tmp/cache? (I tried, but failed.)

[anselmolsm]

@liujianjunhq we've applied that patch to grpcio package. In my previous comment I had only bazel package in mind (which also bundles grpc), I haven't checked tensorflow's build system. In tensorflow's case, it may take even more time to get that PR merged since that depends on tensorflow updating the grpc version it uses. So a short term fix is to apply the patch from that PR (with path adjustments, probably).

[liujianjunhq]

@anselmolsm I found that we could patch grpc as below, and it works. Thanks a lot!
diff --git a/tensorflow/workspace.bzl b/tensorflow/workspace.bzl
index 55d7eb93..33e86087 100755
--- a/tensorflow/workspace.bzl
+++ b/tensorflow/workspace.bzl
@@ -486,6 +486,7 @@ def tf_workspace(path_prefix = "", tf_repo_name = ""):
# WARNING: make sure ncteisen@ and vpai@ are cc-ed on any CL to change the below rule
tf_http_archive(
name = "grpc",

•  patch_file = clean_dep("//third_party:Rename-gettid-functions.patch"),
     sha256 = "67a6c26db56f345f7cee846e681db2c23f919eba46dd639b09462d1b6203d28c",
     strip_prefix = "grpc-4566c2a29ebec0835643b972eb99f4306c4234a3",
     system_build_file = clean_dep("//third_party/systemlibs:grpc.BUILD"),
  

[anselmolsm]

Thanks for fixing this @liujianjunhq .

[tikessler]

I am facing the exact same issue as described above, however I dont really understand how @liujianjunhq mentioned to patch that method. Can you please elaborate further which steps are needed?
Thank you

[anselmolsm]

@muellerti , this is the patch applied by @liujianjunhq to grpc compiled as part of tensorflow package build.

[tikessler]

+1 Thank you

[kumar-nilesh-101]

@anselmolsm I don't know how to apply the patch file, can put instructions for that please