Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Conversation

@matthewrsj
Copy link
Contributor

A version can be missing if the minversion is newer than the previous
version being checked. This is not an error, but should be printed as a
warning to the user in case this is not expected.

Signed-off-by: Matthew Johnson matthew.johnson@intel.com

A version can be missing if the minversion is newer than the previous
version being checked. This is not an error, but should be printed as a
warning to the user in case this is not expected.

Signed-off-by: Matthew Johnson <matthew.johnson@intel.com>
@matthewrsj matthewrsj requested a review from tmarcu March 6, 2018 23:45
@matthewrsj
Copy link
Contributor Author

that travis error doesn't seem related to my change...

@matthewrsj
Copy link
Contributor Author

@tmarcu looks like it is an issue with clrtrust generate running in the container.

@matthewrsj
Copy link
Contributor Author

Got info from clrtrust maintainer (@busykai) that there is an issue with clrtrust in clearlinux:latest. He told me how to fix the makefile to repair this. The fix will not break future fixes to clrtrust, but @busykai will let us know when we can remove it.

In the current clearlinux:latest docker image clrtrust generate is
broken due to /var/lock not existing. To workaround this so our CI isn't
constantly failing mkdir -p this directory. This will not break future
fixes to clrtrust, but the maintainer will alert us when this workaround
can be removed.

Signed-off-by: Matthew Johnson <matthew.johnson@intel.com>
@matthewrsj
Copy link
Contributor Author

Passes \o/

Copy link
Contributor

@tmarcu tmarcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tmarcu tmarcu merged commit b75733a into clearlinux:master Mar 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants