Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sixty-dogs-film.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/vue': patch
---

Remove `treatPendingAsSignedOut` from `useSession` and always return pending session
15 changes: 6 additions & 9 deletions packages/vue/src/composables/useSession.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import type { PendingSessionOptions, UseSessionReturn } from '@clerk/types';
import type { UseSessionReturn } from '@clerk/types';
import { computed } from 'vue';

import type { ToComputedRefs } from '../utils';
import { toComputedRefs } from '../utils';
import { useClerkContext } from './useClerkContext';

type UseSession = (options?: PendingSessionOptions) => ToComputedRefs<UseSessionReturn>;
type UseSession = () => ToComputedRefs<UseSessionReturn>;

/**
* Returns the current [`Session`](https://clerk.com/docs/references/javascript/session) object which provides
Expand All @@ -32,23 +32,20 @@ type UseSession = (options?: PendingSessionOptions) => ToComputedRefs<UseSession
* </div>
* </template>
*/
export const useSession: UseSession = (options = {}) => {
const { sessionCtx, ...clerkContext } = useClerkContext();
export const useSession: UseSession = () => {
const { sessionCtx, clerk } = useClerkContext();

const result = computed<UseSessionReturn>(() => {
if (sessionCtx.value === undefined) {
return { isLoaded: false, isSignedIn: undefined, session: undefined };
}

const pendingAsSignedOut =
sessionCtx.value?.status === 'pending' &&
(options.treatPendingAsSignedOut ?? clerkContext.treatPendingAsSignedOut);
const isSignedOut = sessionCtx.value === null || pendingAsSignedOut;
const isSignedOut = sessionCtx.value === null;
if (isSignedOut) {
return { isLoaded: true, isSignedIn: false, session: null };
}

return { isLoaded: true, isSignedIn: true, session: sessionCtx.value };
return { isLoaded: true, isSignedIn: !!clerk.value?.isSignedIn, session: sessionCtx.value };
});

return toComputedRefs(result);
Expand Down
Loading