-
Notifications
You must be signed in to change notification settings - Fork 422
feat(ui,shared,localizations): Show message in TaskChooseOrganization when org creation disabled
#7486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui,shared,localizations): Show message in TaskChooseOrganization when org creation disabled
#7486
Conversation
🦋 Changeset detectedLatest commit: 01eedf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
TaskChooseOrganization when org creation disabled for usersTaskChooseOrganization when org creation disabled for users
TaskChooseOrganization when org creation disabled for usersTaskChooseOrganization when org creation disabled
TaskChooseOrganization when org creation disabled TaskChooseOrganization when org creation disabled
📝 WalkthroughWalkthroughAdds a guard to TaskChooseOrganization that shows an OrganizationCreationDisabledScreen when user.createOrganizationEnabled is falsy, extracts a reusable TaskChooseOrganizationCardFooter, and wraps the component with withOrganizationCreationEnabledGuard in the export chain. Adds localization strings (taskChooseOrganization.createOrganization.organizationCreationDisabled) and corresponding types in shared localization definitions. Extends FlowMetadata.part union to include 'organizationCreationDisabled'. Adds a test covering the non-creation scenario. Adds changeset entries for minor version bumps of the localizations, ui, and shared packages. Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (48)
🧰 Additional context used📓 Path-based instructions (12)**/*.{js,jsx,ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
packages/**/src/**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
packages/**/src/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
**/*.ts?(x)📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
Files:
**/*.{js,ts,jsx,tsx}📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Files:
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Files:
packages/localizations/**/*📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Files:
**/*⚙️ CodeRabbit configuration file
Files:
**/localizations/**/*.ts⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📚 Learning: 2025-12-12T19:54:17.554ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
🔇 Additional comments (42)
Comment |
c131602 to
79d49f6
Compare
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
79d49f6 to
1378673
Compare
| | 'chooseWallet' | ||
| | 'enterpriseConnections' | ||
| | 'chooseWallet'; | ||
| | 'organizationCreationDisabled'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep the keys similar for a group of flows e.g. chooseOrganizationDisabled vs organizationCreationDisabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think choose could be confusing here, as this is based on the creation action - eg: if the user has existing memberships to choose, then they wouldn't see that flow step
…n` when org creation disabled (#7486)
Description
Update
TaskChooseOrganizationscreen to show a message whenuser.createOrganizationEnabledis disabled.This fixes an UX issue where personal accounts are disabled for an instance, and users are not allowed to create orgs, therefore getting stuck in the create org form.
CleanShot.2025-12-16.at.18.52.48.mp4
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.