Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Dec 17, 2025

Description

Add missing selected and hover states to RolesListItem. Matches values from https://github.com/clerk/javascript/blob/release/core-2/packages/clerk-js/src/ui/elements/PhoneInput/index.tsx#L95-L100

BEFORE AFTER
Screenshot 2025-12-17 at 2 54 02 PM Screenshot 2025-12-17 at 2 53 37 PM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

🦋 Changeset detected

Latest commit: 4b59461

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Dec 17, 2025 7:57pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch alexcarpenter/fix-role-select-backgrounds

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be in core 3 as well?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7497

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7497

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7497

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7497

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7497

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7497

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7497

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7497

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7497

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7497

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7497

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7497

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7497

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7497

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7497

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7497

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7497

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7497

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7497

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7497

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7497

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7497

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7497

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7497

commit: 4b59461

@alexcarpenter alexcarpenter enabled auto-merge (squash) December 17, 2025 20:05
@alexcarpenter alexcarpenter merged commit 0f4c27e into release/core-2 Dec 17, 2025
44 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/fix-role-select-backgrounds branch December 17, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants