Skip to content

hotfix/cp-11157-init-future-never-completes-when-initialization-fails#98

Merged
snuricp merged 1 commit intomasterfrom
hotfix/cp-11157-init-future-never-completes-when-initialization-fails
Apr 29, 2026
Merged

hotfix/cp-11157-init-future-never-completes-when-initialization-fails#98
snuricp merged 1 commit intomasterfrom
hotfix/cp-11157-init-future-never-completes-when-initialization-fails

Conversation

@unnaticleverpush
Copy link
Copy Markdown
Contributor

@unnaticleverpush unnaticleverpush commented Apr 21, 2026

Prevent multiple replies and ensure init() Future always resolves


Summary by cubic

Guarantees the Flutter init() Future always resolves on CleverPush initialization failure and prevents multiple MethodChannel replies. Addresses Linear CP-11157 to stop hangs and “already replied” errors.

  • Bug Fixes
    • Add replied guard to call replySuccess exactly once across success and failure callbacks in CleverPushPlugin.
    • On failure, still resolve the method call and emit CleverPush#handleInitialized with success: false and a null-safe failureMessage.

Written for commit c3f8a56. Summary will update on new commits.

Prevent multiple replies and ensure init() Future always resolves
@unnaticleverpush unnaticleverpush self-assigned this Apr 21, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@snuricp snuricp merged commit b7bd1f9 into master Apr 29, 2026
3 checks passed
@snuricp snuricp deleted the hotfix/cp-11157-init-future-never-completes-when-initialization-fails branch April 29, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants