feature/cp-11047-add-uiscene-life-cycle-support#99
Merged
Conversation
Added UIScene Life Cycle Support for iOS in Flutter.
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="ios/Classes/CleverPushPlugin.h">
<violation number="1" location="ios/Classes/CleverPushPlugin.h:4">
P1: The `#ifdef FlutterSceneLifeCycleDelegate` guard is incorrect for protocol availability, so scene lifecycle protocol conformance is never enabled.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Added UIScene Life Cycle Support for iOS in Flutter.
akshay-g-jadhav
approved these changes
Apr 24, 2026
unnaticleverpush
approved these changes
Apr 24, 2026
snuricp
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added UIScene Life Cycle Support for iOS in Flutter.
Summary by cubic
Adds UIScene lifecycle support to the iOS Flutter plugin to handle scene-based launches on iOS 13+. Implements CP-11047 and fixes key window resolution and dark mode detection in multi‑scene apps.
CleverPushPluginadoptsFlutterSceneLifeCycleDelegate(when available) and registers viaaddSceneDelegate:.scene:willConnectToSession:options:and convertsUISceneConnectionOptionstolaunchOptions(notifications, URLs, shortcuts, user activities) for initialization.UIWindowScene, then app windows.CPStoryViewFlutterdark mode detection to read the foreground-active scene’s window, with fallback.Written for commit 9e1f9f2. Summary will update on new commits.