Skip to content

feature/cp-11047-add-uiscene-life-cycle-support#99

Merged
snuricp merged 2 commits intomasterfrom
feature/cp-11047-add-uiscene-life-cycle-support
Apr 29, 2026
Merged

feature/cp-11047-add-uiscene-life-cycle-support#99
snuricp merged 2 commits intomasterfrom
feature/cp-11047-add-uiscene-life-cycle-support

Conversation

@cpandya25
Copy link
Copy Markdown
Contributor

@cpandya25 cpandya25 commented Apr 22, 2026

Added UIScene Life Cycle Support for iOS in Flutter.


Summary by cubic

Adds UIScene lifecycle support to the iOS Flutter plugin to handle scene-based launches on iOS 13+. Implements CP-11047 and fixes key window resolution and dark mode detection in multi‑scene apps.

  • New Features
    • CleverPushPlugin adopts FlutterSceneLifeCycleDelegate (when available) and registers via addSceneDelegate:.
    • Adds scene:willConnectToSession:options: and converts UISceneConnectionOptions to launchOptions (notifications, URLs, shortcuts, user activities) for initialization.
    • Improves key window lookup on iOS 13+ and iOS 15+ using the registrar’s view controller window, the foreground UIWindowScene, then app windows.
    • Updates CPStoryViewFlutter dark mode detection to read the foreground-active scene’s window, with fallback.

Written for commit 9e1f9f2. Summary will update on new commits.

Added UIScene Life Cycle Support for iOS in Flutter.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="ios/Classes/CleverPushPlugin.h">

<violation number="1" location="ios/Classes/CleverPushPlugin.h:4">
P1: The `#ifdef FlutterSceneLifeCycleDelegate` guard is incorrect for protocol availability, so scene lifecycle protocol conformance is never enabled.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread ios/Classes/CleverPushPlugin.h Outdated
Added UIScene Life Cycle Support for iOS in Flutter.
@snuricp snuricp merged commit 0fa710c into master Apr 29, 2026
3 checks passed
@snuricp snuricp deleted the feature/cp-11047-add-uiscene-life-cycle-support branch April 29, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants