Skip to content

feature/cp-9876-ios-dynamic-deep-links-track-event-pass-dynamic-deep-link#352

Draft
cpandya25 wants to merge 2 commits intomasterfrom
feature/cp-9876-ios-dynamic-deep-links-track-event-pass-dynamic-deep-link
Draft

feature/cp-9876-ios-dynamic-deep-links-track-event-pass-dynamic-deep-link#352
cpandya25 wants to merge 2 commits intomasterfrom
feature/cp-9876-ios-dynamic-deep-links-track-event-pass-dynamic-deep-link

Conversation

@cpandya25
Copy link
Copy Markdown
Contributor

@cpandya25 cpandya25 commented Nov 27, 2025

Implemented the feature of passing deepLinkID in the track event functionality.


Summary by cubic

Passes deeplinkId from notification URLs into trackEvent payloads to capture deep link context. Stores the last deeplinkId on notification open and attaches it to subsequent events within 1 hour (Linear CP-9876).

  • New Features
    • Added CPUtils method to read a query parameter from a URL.
    • On notification open, parse deeplinkId from the URL; store or clear it in user defaults with a timestamp.
    • In trackEvent, include the stored deeplinkId when it was captured within the last hour.

Written for commit 38c17ea. Summary will update automatically on new commits.


Note

Parses deeplinkId from notification URLs, stores it briefly, and includes it in subsequent trackEvent payloads.

  • Core (CleverPushInstance.m):
    • On notification open, extract deeplinkId from notification.url and persist timestamped in NSUserDefaults; clear if absent.
    • In trackEvent, read recent deeplinkId (<=1h) and add it to subscription/conversion request payload.
  • Utils (CPUtils):
    • Add getQueryParameterFromURL:forKey: to retrieve specific query params.
  • Storage (CleverPushUserDefaults.h):
    • Add keys CLEVERPUSH_LAST_DEEPLINK_ID_KEY and CLEVERPUSH_LAST_DEEPLINK_TIME_KEY.

Written by Cursor Bugbot for commit 38c17ea. This will update automatically on new commits. Configure here.

…link

implemented the feature of passing deepLinkID in the track event functionality.
@cpandya25 cpandya25 marked this pull request as ready for review November 27, 2025 09:37
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 12

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment thread CleverPush/Source/CleverPushInstance.m
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="CleverPush/Source/CleverPushInstance.m">

<violation number="1" location="CleverPush/Source/CleverPushInstance.m:1956">
`deeplinkId` persistence only runs for auto-handled deep links, so opening manual deep links never updates/clears the stored value and `trackEvent` sends stale IDs.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

Comment thread CleverPush/Source/CleverPushInstance.m Outdated
…link

implemented the feature of passing deepLinkID in the track event functionality.
@cpandya25 cpandya25 marked this pull request as draft April 1, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant