Conversation
…link implemented the feature of passing deepLinkID in the track event functionality.
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 12
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="CleverPush/Source/CleverPushInstance.m">
<violation number="1" location="CleverPush/Source/CleverPushInstance.m:1956">
`deeplinkId` persistence only runs for auto-handled deep links, so opening manual deep links never updates/clears the stored value and `trackEvent` sends stale IDs.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
…link implemented the feature of passing deepLinkID in the track event functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the feature of passing deepLinkID in the track event functionality.
Summary by cubic
Passes deeplinkId from notification URLs into trackEvent payloads to capture deep link context. Stores the last deeplinkId on notification open and attaches it to subsequent events within 1 hour (Linear CP-9876).
Written for commit 38c17ea. Summary will update automatically on new commits.
Note
Parses deeplinkId from notification URLs, stores it briefly, and includes it in subsequent trackEvent payloads.
deeplinkIdfromnotification.urland persist timestamped inNSUserDefaults; clear if absent.trackEvent, read recentdeeplinkId(<=1h) and add it tosubscription/conversionrequest payload.getQueryParameterFromURL:forKey:to retrieve specific query params.CLEVERPUSH_LAST_DEEPLINK_ID_KEYandCLEVERPUSH_LAST_DEEPLINK_TIME_KEY.Written by Cursor Bugbot for commit 38c17ea. This will update automatically on new commits. Configure here.