Skip to content
This repository was archived by the owner on Apr 23, 2023. It is now read-only.

Updated Pipeline to improve consistency#18

Open
clicky wants to merge 2 commits intomainfrom
better-pipeline
Open

Updated Pipeline to improve consistency#18
clicky wants to merge 2 commits intomainfrom
better-pipeline

Conversation

@clicky
Copy link
Owner

@clicky clicky commented Nov 11, 2022

Description

The pipeline does not currently draw any annotations to the right scale. This PR fixes that and adds a lot more support for annotation rendering inside the pipeline. It doesn't give perfect full support (Which is the goal). But it vastly improves it for now.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tried the following annotation items, and this best describes the current support
    image

For reference, here is the current level of support, without this PR
image

Checklist:

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the docs
  • My changes generate no new warnings

@karimi
Copy link
Collaborator

karimi commented Nov 16, 2022

This looks great! I'm not sure why you have the leader say unsupported it works just fine for me
crash-leader

One thing I noticed is that the DimAligned and DimAngle preview show the value twice:
crash-annotations

@clicky
Copy link
Owner Author

clicky commented Nov 19, 2022

Thanks for taking a look @karimi,

Regarding leaders, this is why -> https://github.com/clicketyclackety/Crash/blob/8502b36ba0caaa78adf253cbf7dcc7f85034cb11/Crash/UI/DrawMethods.cs#L275-L279

I've found that when I use the pipeline. Annotations do not scale correctly and seem very small. So I just drew in the text on top. I'm unsure why yours scales correctly but mine doesn't? Maybe it has something to do with the current DimensionStyle?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

2 participants

Comments