-
Notifications
You must be signed in to change notification settings - Fork 36
Support for Rails 6.1.4.1 and onward (Until 7) + Supporting CI Changes. #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Several tests are broken because rails/rails#40969 & rails/rails#40943 were fixed/closed by rails/rails@b52b804. The net effect that the original replace_keys has been updated to have a new argument called force The stack trace comes from the To fix while preserving existing behaviour we should set the force variable to true; however, this has the negative side effect of re-introducing the bugs this fixes. Will investigate other solutions. |
|
I've made some changes to better support continuous integration. Previously bundler cache was set to true. This had caused CI to run the following command /opt/hostedtoolcache/Ruby/2.6.8/x64/bin/bundle config --local deployment trueWhen you used bundle config to set the deployment to true the gemfile must match the gemfile.lock. This meant that if you changed a dependency in the gemspec you were forced to run I felt that this was unintuitive and a lot of work, I also felt that the setting deployment to true was unnecessary and decided to do the bundle install manually. This results in us no longer needing to update the lock files. Since all of the required libraries are publicly available in ruby gems and on github I think this is safe. This allowed us to delete the lock files in d9e7c8d. |
|
rails/rails@ccb13cb renames |
rhemsing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Joseph and I chatted through the downsides of not including lock files. I think we're probably fine because of the nature of this gem -- it's very specific functionality that is covered by CI.
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for other reviewers - Joseph and I chatted about this -- this will ensure that if specs for one Rails version fail, it won't auto-fail the other specs for other versions
Presently we do not have support for rails 6.1.4.1.
The objective of this pull request is to fix tests and ensure that the polymorphic integer type works with rails 6.1.4.1 as well as update CI to test this functionality.
Several tests are broken because rails/rails#40969 & rails/rails#40943 were fixed/closed by rails/rails@b52b804.
The net effect that the original replace_keys has been updated to have a new argument called force
I've made some changes to better support continuous integration.
fixes #38