-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Currently, the resize tests use a hash-helper to generate a valid hash for testing urls. This hash-helper does not use the same hash generation code as the actual API uses (which is bad because of duplication, maintenance and testing).
It would be better if the tests could use the same hash generation code as the application, however that is made difficult because (currently):
- Hash generation doesn't take a URL, but takes actions and data.
- The actions and data are set on
req.paramsby the route-checker middleware. - The resize tests are currently written in a way that you pass the beginning of a url, which doesn't work for any querystring params.
jack828
Metadata
Metadata
Assignees
Labels
No labels