Handle @ in tag names from lxml >= 6.0 HTML parser#63
Draft
drew-myers wants to merge 1 commit into
Draft
Conversation
drew-myers
force-pushed
the
fix-keyerror-at-in-tag-name
branch
from
801e8ce to
15905a3
Compare
lxml 6.0's HTML parser keeps pseudo-tags like <shawn@iluminarlighting.com> (common in quoted reply headers of the form Name <addr@domain>) as real elements with @ in the tag name. slice_tree then round-trips them through getelementpath + find, and the elementpath tokenizer raises KeyError: '@' because @ is the attribute axis token and isn't valid mid-NameTest. Extend the existing :-in-tag-name HACK in get_html_tree to also rewrite tags containing @ to <span>, stashing the original name in __tag_name so render_html_tree can restore it.
drew-myers
force-pushed
the
fix-keyerror-at-in-tag-name
branch
from
15905a3 to
e6979eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to lxml >6.0 in closeio due to a security vuln and it caused this:
https://closeio.sentry.io/issues/7461358574/?project=4506066590433280
Extend the existing :-in-tag-name HACK in get_html_tree to also rewrite tags containing @ to , stashing the original name in __tag_name so render_html_tree can restore it.
Ships a test to verify the case linked above.