feat(on): add generic WorkflowRunner interface#7
Open
darlanalves wants to merge 4 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
WorkflowRunnerinterface topackages/on/src/types.tsthat is generic overTStep,TContext, andTOutputand defaults toStepDefinition,WorkflowContext, andStepOutputrespectively.run(step, context): Promise<TOutput>modeling an asynchronous execution that returns an exit code, stdout/stderr and the executed command.StepDefinition,WorkflowContext,StepOutput) so implementations can import and specialize the runner type consistently.Testing
pnpm nx run on:build, which completed successfully.pnpm nx run on:test, which executed but failed in this environment due to missing Docker (spawn docker ENOENT).src/cli.spec.tswith 3 failing tests, which is caused by the unavailable Docker runtime rather than the new type addition.Codex Task