Updated all logging to be lazy-loaded

[eandersson]

The current logging isn't lazy-loaded. This means that all statements are evaluated even with logging disabled. This can have pretty a measurable impact on performance.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: eandersson / name: Erik Olof Gunnar Andersson (897c4f1)

[nosammai]

Testing with the provided benchmark, this makes a huge difference in performance:

Before fix:

❯ python3.8 benches/large_resource_set.py TagAssetBenchmark
Filter    : resource["IamInstanceProfile"]["Arn"].matches("(.*)(?=Enterprise-Reserved-CloudCustodian.*)") && (resource["Tags"].filter(x, x["Key"] == "ASSET")[0]["Value"] != "CLOUDCUSTODIAN" && resource["Tags"].filter(x, x["Key"] == "ASSET")[0]["Value"] != "CLOUDCORESERVICES" && present(resource["Tags"].filter(x, x["Key"] == "ASSET")[0]["Value"]))
Resources : 1,000
Total Time: 19,423.9 ms
Range : 13.0 ms - 172.3 ms
Mean  : 19.19 ms
Median: 15.52 ms

After Fix:

❯ python3.8 benches/large_resource_set.py TagAssetBenchmark
Filter    : resource["IamInstanceProfile"]["Arn"].matches("(.*)(?=Enterprise-Reserved-CloudCustodian.*)") && (resource["Tags"].filter(x, x["Key"] == "ASSET")[0]["Value"] != "CLOUDCUSTODIAN" && resource["Tags"].filter(x, x["Key"] == "ASSET")[0]["Value"] != "CLOUDCORESERVICES" && present(resource["Tags"].filter(x, x["Key"] == "ASSET")[0]["Value"]))
Resources : 1,000
Total Time: 2,690.9 ms
Range : 2.0 ms - 8.9 ms
Mean  : 2.60 ms
Median: 2.45 ms

[eandersson]

Had to close and re-open PR to fix issues with SLA not being recognized.

[kapilt]

lgtm

[kapilt]

looks like one test failure on test_trace_decorator to address.

[eandersson]

looks like one test failure on test_trace_decorator to address.

Ops. Missed that one. Fixed.

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6622fe6) compared to base (50f9e8b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines         2602      2601    -1     
=========================================
- Hits          2602      2601    -1     

Impacted Files	Coverage Δ
src/celpy/__init__.py	100.00% <100.00%> (ø)
src/celpy/__main__.py	100.00% <100.00%> (ø)
src/celpy/celtypes.py	100.00% <100.00%> (ø)
src/celpy/evaluation.py	100.00% <100.00%> (ø)
src/xlate/c7n_to_cel.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.