release: Rename assets with kernel arch string #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
I have a little question, should we name |
RuoqingHe
force-pushed
the
2025-03-28-rename-assets-with-arch
branch
from
c312680 to
cb26ca9
Compare
RuoqingHe
commented
Apr 4, 2025
| upload_url: ${{ steps.create_release.outputs.upload_url }} | ||
| asset_path: arch/arm64/boot/Image.gz | ||
| asset_name: Image.gz | ||
| asset_name: Image-arm64.gz |
Member
Author
There was a problem hiding this comment.
Using Image-<arch>.gz format here
RuoqingHe
force-pushed
the
2025-03-28-rename-assets-with-arch
branch
from
cb26ca9 to
becbeed
Compare
Once we are releasing with more architectures (like riscv64), assets naming with image format will conflict with other architecture when using the same format. Append with kernel arch string to avoid possible confliction. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
force-pushed
the
2025-03-28-rename-assets-with-arch
branch
from
becbeed to
132835c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we are releasing with more architectures (like riscv64), assets naming with image format will conflict with other architecture when using the same format. Append with kernel arch string to avoid possible confliction.
Signed-off-by: Ruoqing He heruoqing@iscas.ac.cn