Apt configure yaml test#108
Merged
blackboxsw merged 4 commits intoJun 11, 2020
Merged
Conversation
blackboxsw
requested changes
Jun 10, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
minor change for the schema validation template and we'll land it
Comment on lines
+153
to
+157
| echo "Expect schema failure on invalid_apt" | ||
| if [ "$SERIES" = "xenial" ]; then | ||
| echo "Xenial does not have jsonschema dependecy, making this type of checking to not work on it" | ||
| fi | ||
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_apt.yaml |
Collaborator
There was a problem hiding this comment.
as with your other PR let's just pull this logic into the xenial non-xenial case
Suggested change
| echo "Expect schema failure on invalid_apt" | |
| if [ "$SERIES" = "xenial" ]; then | |
| echo "Xenial does not have jsonschema dependecy, making this type of checking to not work on it" | |
| fi | |
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_apt.yaml | |
| if [ "$SERIES" = "xenial" ]; then | |
| echo "Xenial does not have jsonschema dependecy, making this type of checking to not work on it" | |
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_apt.yaml && echo "SUCCESS: xenial allowed invalid schema because it lacks python3-jsonschema dep" || echo "FAILURE: Xenial failed invalid_schema which it should have passed" | |
| else | |
| echo "Expect schema failure on invalid_apt" | |
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_apt.yaml || echo "SUCCESS: rejected invalid schema" | |
| fi |
| lxc file push invalid_apt.yaml $name/var/tmp/ | ||
|
|
||
| lxc exec $name -- cloud-init status --wait --long | ||
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_apt.yaml || echo "FAILURE" |
Collaborator
There was a problem hiding this comment.
Let's just add an echo
Suggested change
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_apt.yaml || echo "FAILURE" | |
| echo "Expecting no failures on invalid schema pre-upgrade because no schema apt defined" | |
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_apt.yaml || echo "FAILURE" |
lucasmoura
force-pushed
the
apt_configure_yaml_test
branch
from
655aca1 to
5ff2583
Compare
lucasmoura
force-pushed
the
apt_configure_yaml_test
branch
from
5ff2583 to
f5c6772
Compare
Author
|
@blackboxsw done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual verification for #357