Add locale yaml schema manual check#109
Merged
Merged
Conversation
blackboxsw
reviewed
Jun 10, 2020
Comment on lines
+52
to
+56
| echo "Expect schema failure on invalid_locale" | ||
| if [ "$SERIES" = "xenial" ]; then | ||
| echo "Xenial does not have jsonschema dependecy, making this type of checking to not work on it" | ||
| fi | ||
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_locale.yaml |
Collaborator
There was a problem hiding this comment.
Suggested change
| echo "Expect schema failure on invalid_locale" | |
| if [ "$SERIES" = "xenial" ]; then | |
| echo "Xenial does not have jsonschema dependecy, making this type of checking to not work on it" | |
| fi | |
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_locale.yaml | |
| if [ "$SERIES" = "xenial" ]; then | |
| echo "Xenial does not have jsonschema dependecy, making this type of checking to not work on it" | |
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_locale.yaml || echo "FAILURE: xenial should have passed invalid_schema because it has no jsonschema dep" | |
| else | |
| lxc exec $name -- cloud-init devel schema -c /var/tmp/invalid_locale.yaml || echo "SUCCESS: $SERIES rejected invalid schema" | |
| fi | |
lucasmoura
force-pushed
the
locale_schema_yaml
branch
from
52d9aa5 to
158bdbf
Compare
Author
|
@blackboxsw done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual check for 335