Initial dump of Compositions alpha implementation#7
Initial dump of Compositions alpha implementation#7justinsb merged 4 commits intocloud-native-compositions:mainfrom
Conversation
a-hilaly
requested review from
a-hilaly and
matthchr
and removed request for
matthchr
|
#8 << user guide dump |
| const ( | ||
| Ready ConditionType = "Ready" | ||
| // Error implies the last reconcile attempt failed | ||
| Error ConditionType = "Error" |
There was a problem hiding this comment.
Is the implication that this condition is "fatal", as compared to a situation where Ready=False, but that may mean "we're just not done yet"?
There was a problem hiding this comment.
Error is a catch all for any error (temporary or otherwise) when we reconcile a composition. This may be temporary errors such as unable to reach k8s server, grpc server etc. We have a separate Waiting condition value to indicate we are waiting for something (we are not done yet).
matthchr
left a comment
matthchr
left a comment
There was a problem hiding this comment.
I didn't go over this with a fine-tooth comb (there's a lot), but my major comments were resolved or added to TODOs to do later.
Approved.
| Type ExpanderType `json:"type"` | ||
|
|
||
| // ExpanderConfig GVK | ||
| Config ExpanderConfigGVK `json:"config"` |
There was a problem hiding this comment.
It is required for helm
There was a problem hiding this comment.
My point I guess is, either it should have kubeuilder:required or it should be json:omitempty.
5 participants
This is the initial dump of the Compositions code that we have been demoing in the weekly meetings.
Source: https://github.com/GoogleCloudPlatform/k8s-config-connector/tree/master/experiments/compositions
We want to follow up with commits to: