Skip to content

Add subject.#104

Merged
markpeek merged 3 commits into
cloudevents:masterfrom
n3wscott:add_subject
Apr 9, 2019
Merged

Add subject.#104
markpeek merged 3 commits into
cloudevents:masterfrom
n3wscott:add_subject

Conversation

@n3wscott
Copy link
Copy Markdown
Member

@n3wscott n3wscott commented Apr 8, 2019

Fixes #103

Scott Nichols added 3 commits April 8, 2019 15:18
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
@n3wscott n3wscott requested a review from markpeek April 8, 2019 23:32
@n3wscott
Copy link
Copy Markdown
Member Author

n3wscott commented Apr 9, 2019

Implements cloudevents/spec#406

Copy link
Copy Markdown
Contributor

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markpeek markpeek merged commit 71373da into cloudevents:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants