-
Notifications
You must be signed in to change notification settings - Fork 61
Expose iter #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose iter #55
Conversation
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
slinkydeveloper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out the warnings (run cargo fix and then cargo fmt, so it fixes the imports)
Also, should the iterators implement ExactSizeIterator, since you know straight from the beginning how many attributes you have? If you need the code to calculate the number of attributes, i think you can find it in v1::EventFormatDeserializer
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Would some values being |
No because you calculate with a sum (like done in v1::EventFormatSerializer) the exact number of available attributes |
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
slinkydeveloper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit and we're ready to merge it!
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Exposes the Iterator functionality of Attributes.
Fix #15