Improve api #57
Merged
Improve api #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com> Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Member
|
Can you remove from this PR the changes to cloudevents-sdk-actix-web? |
Contributor
Author
Done! Also, should I remove the old function call? |
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com> Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com> Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
…into improve_api Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com> Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com> Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Member
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
Minor nits and lgtm
I'm fine with async-trait, i've tried locally and using a concrete type it's just too hard
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
slinkydeveloper
approved these changes
Jun 9, 2020
Member
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
convert the pr to ready to review
Member
|
You need to translate the example that uses reqwest to use these new apis |
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
slinkydeveloper
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved API call for
cloudevents-sdk-reqwest, replacingresponse_to_event()andevent_to_request()