Skip to content

initial spec#1

Merged
duglin merged 1 commit into
cloudevents:masterfrom
duglin:initalSpec
Dec 14, 2017
Merged

initial spec#1
duglin merged 1 commit into
cloudevents:masterfrom
duglin:initalSpec

Conversation

@duglin
Copy link
Copy Markdown
Collaborator

@duglin duglin commented Dec 11, 2017

Signed-off-by: Doug Davis dug@us.ibm.com
Signed-off-by: Austen Collins austen@serverless.com

Copy link
Copy Markdown
Contributor

@austencollins austencollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the new properties that were added in by a single contributor which need to be discussed first, these look fine.

Comment thread spec.md Outdated
* Required
* Unique per producer

### correlation-id
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duglin Could we move this to the Context Attributes Backlog. This was suggested in the Google doc by a contributor, but wasn't agreed to by anyone else. We need to discuss and review new properties before adding them in.

Comment thread spec.md Outdated
* Constraints:
* Optional

### causation-id
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duglin Could we move this to the Context Attributes Backlog. This was suggested in the Google doc by a contributor, but wasn't agreed to by anyone else. We need to discuss and review new properties before adding them in.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this comment didn't go away when I moved the entry, but I did move it as you can see.

@duglin
Copy link
Copy Markdown
Collaborator Author

duglin commented Dec 12, 2017

@ac360 can you add a comment saying that you agree with the edit and are "signing off" on it - in essence signing a DCO, just so we transfer right to the group?

@duglin duglin force-pushed the initalSpec branch 2 times, most recently from 05776cb to c126153 Compare December 12, 2017 21:30
Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Austen Collins <austen@serverless.com>
@austencollins
Copy link
Copy Markdown
Contributor

These edits look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants