spec: fix some typo in chinese translation#1068
Merged
Merged
Conversation
Signed-off-by: Ranger Tsao <cao.zhifu@gmail.com>
duglin
reviewed
Aug 30, 2022
| - 示例 | ||
| - com.github.pull.create | ||
| - com.example.object.delete.v2 | ||
| - com.github.pull_request.opened |
Collaborator
There was a problem hiding this comment.
seems like we should make this change in the English version too for consistency... if we want to change it
duglin
reviewed
Aug 30, 2022
| - com.github.pull.create | ||
| - com.example.object.delete.v2 | ||
| - com.github.pull_request.opened | ||
| - com.example.object.deleted.v2 |
Collaborator
|
@JieDing can you review? thanks |
Member
Sure, I'll review it. |
JieDing
reviewed
Aug 30, 2022
Member
JieDing
left a comment
JieDing
left a comment
There was a problem hiding this comment.
Thanks a ton for your careful check for the translation. Here are some suggestions.
JieDing
reviewed
Aug 30, 2022
| - 描述: `data` 值的内容类型。 此属性使 `data` 能够承载任何类型的内容， | ||
| 因此格式和编码可能与所选事件格式的不同。 | ||
| 例如，使用 [JSON envelope](../../formats/json-format.md#3-envelope)格式呈现的事件可能在数据中携带 XML 的payload，这个属性可以用来通知消费者 | ||
| 例如，使用 [JSON envelope](../../formats/json-format.md#3-envelope)格式呈现的事件可能在数据中携带 XML 的 payload，这个属性可以用来通知消费者 |
Member
There was a problem hiding this comment.
Suggested change
| 例如，使用 [JSON envelope](../../formats/json-format.md#3-envelope)格式呈现的事件可能在数据中携带 XML 的 payload，这个属性可以用来通知消费者 | |
| 例如，使用 [JSON envelope](../../formats/json-format.md#3-envelope)格式呈现的事件可能在数据中携带 XML 的有效负载，这个属性可以用来通知消费者 |
Collaborator
|
@boliza did you want to make any of the suggested updates? |
Contributor
Author
|
sorry for a bit busy these days. will update this pr doday |
Signed-off-by: Ranger Tsao <cao.zhifu@gmail.com>
Collaborator
|
@JieDing are you ok with the PR now? |
Member
Collaborator
|
Approved on the 9/15 call |
sasha-tkachev
pushed a commit
to sasha-tkachev/cloudevents-spec
that referenced
this pull request
Oct 14, 2022
* spec: fix some typo in chinese translation Signed-off-by: Ranger Tsao <cao.zhifu@gmail.com> * spec: apply review comment Signed-off-by: Ranger Tsao <cao.zhifu@gmail.com> Signed-off-by: Ranger Tsao <cao.zhifu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ranger Tsao cao.zhifu@gmail.com
fix some typo and one broken link