-
Notifications
You must be signed in to change notification settings - Fork 612
Add property-bucket to correlate multiple events associated with a serverless application #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,19 +209,25 @@ that contains both context and data). | |
| [RFC 2046](https://tools.ietf.org/html/rfc2046) | ||
| * For Media Type examples see [IANA Media Types](http://www.iana.org/assignments/media-types/media-types.xhtml) | ||
|
|
||
| ### extensions | ||
| * Type: Map <String, Object> | ||
| * Description: This is for additional metadata and this does not have a | ||
| mandated structure. This enables a place for custom fields a producer or | ||
| middleware might want to include and provides a place to test metadata before | ||
| adding them to the CloudEvents specification. TBD - Determine a shorter | ||
| prefix for this (e.g. OpenAPI uses “x-”) | ||
| ### application-properties | ||
| * Type: <Key Value> | ||
| * Description: A list of “key : value” pairs providing information about the event, which are | ||
| used by an event-based application. The “key : value” pairs should be in flat structure. | ||
| The value should be a string. There should be no duplication of keys. | ||
| One usage example: an application workflow can use a "key:value" to correlate multiple events | ||
| (from different event sources) asscociated with a serverless application workflow. | ||
| * Constraints: | ||
| * OPTIONAL | ||
| * If present, MUST contain at least one entry | ||
| * MANDATORY | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/MANDATORY/REQUIRED/ |
||
| * MUST be in the format of <key value> pair. | ||
| * Examples: | ||
| * authorization data | ||
|
|
||
| application-properties | ||
| { | ||
| "building address": "12 Main Street, Copenhagen, Denmark, 123456" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing |
||
| "floor": "2" | ||
| "apartmentId": "345" | ||
| "sensor-location": "room1.window2" | ||
| } | ||
|
|
||
| ### data | ||
| * Type: Arbitrary payload | ||
| * Description: The event payload. The payload depends on the event-type, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be easier to just define this as a Map and say the "value" MUST be a "string" instead of an "Any". That would remove the need for most of the rules specified below because they would be implicit/obvious. But if you do keep any of the rules then they should use MUST instead of "should".