NATS transport binding#215
Conversation
|
@ColinSullivan1 please rebase the PR/branch. |
29ffc30 to
73cba4a
Compare
|
@sslavic , thanks for the heads up, I've rebased. |
|
@ColinSullivan1 just please list the NATS transport binding in readme.md https://github.com/cloudevents/spec#cloudevents-documents Other than that, LGTM. |
|
@sslavic - Thanks, I'll add that. Just confirming, do I set v0.1 as latest release? I notice this PR has a v0.1 label. |
|
It has IMO for NATS transport binding document just master/draft reference would be enough for now. Later when next release is made, references for the documents in the release would be updated. |
|
Thanks @sslavic . |
|
CI/href failure is real but expected/ok until PR is merged. |
|
Good to see this @ColinSullivan1, looks like the Makefile needs a rebase though. |
|
I think the rebase is off a bit |
|
Yes, sorry, will fix. |
17c2934 to
2abfa04
Compare
Signed-off-by: Colin Sullivan <colin@synadia.com>
2abfa04 to
3785158
Compare
|
Approved on 6/7 call |
I'd like to propose a NATS transport binding for CloudEvents, similar to the HTTP binding and proposed MQTT and AMQP bindings. This PR borrows heavily from the MQTT proposal.
Signed-off-by: Colin Sullivan colin@synadia.com