Skip to content

Enable phrase checker for webhook spec #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duglin merged 1 commit into from
May 25, 2018
Merged

Enable phrase checker for webhook spec #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ all: verify

verify:
@echo Running href checker:
@# Use "-x" if you want to skip exernal links
@# Use "-x" if you want to skip external links
@tools/verify-links.sh -v .
@echo Running the spec phrase checker:
@tools/verify-specs.sh -v spec.md extensions.md json-format.md http-transport-binding.md
@tools/verify-specs.sh -v spec.md extensions.md json-format.md http-transport-binding.md http-webhook.md
@echo Running the doc phrase checker:
@tools/verify-docs.sh -v .
2 changes: 1 addition & 1 deletion http-webhook.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ If the delivery target does not allow delivery of the events or does not expect
delivery of events and nevertheless handles the HTTP OPTIONS method, the
existing response ought not to be interpreted as consent, and therefore the
handshake cannot rely on status codes. If the delivery target otherwise does
not handle the HTTP OPTIONS method, it should respond with HTTP status code
not handle the HTTP OPTIONS method, it SHOULD respond with HTTP status code
405, as if OPTIONS were not supported.

The OPTIONS response SHOULD include the [Allow][Allow] header indicating the
Expand Down