Remove explicit extension attribute#228
Closed
evankanderson wants to merge 1 commit into
Closed
Conversation
evankanderson
force-pushed
the
master
branch
2 times, most recently
from
5eeff5e to
0f7b748
Compare
Remove explicit `extensions` attribute in favor of additional "bare" keys in the top-level context. Ref: 2018-05-30 WG meeting: https://docs.google.com/document/d/1OVF68rpuPK5shIHILK9JOqlZBbfe91RNzQ7u_P7YCDE/edit# Signed-off-by: Evan Anderson <argent@google.com>
Collaborator
|
@evankanderson is this a dup of: #225 ? |
Contributor
Author
|
Maybe -- I realized I'd forgotten to squash the PR, and meant to cancel before hitting create. #225 doesn't load for me right now. |
Contributor
Author
|
Yep, it's a dup. I didn't push on Thursday, and you got around to it while I was travelling on Friday. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove explicit
extensionsattribute in favor of additional "bare" keys in the top-level context.Ref: 2018-05-30 WG meeting:
https://docs.google.com/document/d/1OVF68rpuPK5shIHILK9JOqlZBbfe91RNzQ7u_P7YCDE/edit#
Signed-off-by: Evan Anderson argent@google.com