Apache Pulsar Transport Binding#237
Conversation
|
CI failure, while real, is ok since it'll be automatically fixed when we merge. |
|
thank you @duglin . do I need to fix it now? |
|
|
||
| properties: { | ||
| CE-CloudEventsVersion: "0.1" | ||
| CE-EventType: "org.apache.pulsar.someevent" |
There was a problem hiding this comment.
spacing on this line seems off
There was a problem hiding this comment.
do you need quotes around the names?
There was a problem hiding this comment.
yes. we need quotes around the names, since the names are strings.
added quotes and fix the spacing.
|
Minor thing, but can you wrap the text at 80 columns? Most of this does do that but there are places where it doesn't - just so we're consistent. |
|
Can you modify the Makefile so this md file is run thru the verify-specs.sh checker? |
wrapped the text at 80 columns
verify-specs.sh seems to glob the files suffixed with |
|
verify-specs.sh is called with a fixed list of md file in the Makefile since not all md files need RFC2119 keywords checked. |
|
Make sure you sign all of our commits -the DCO checker isn't happy. And thanks for the quick fixes |
*Motivation* Apache Pulsar is a distributed pub/sub messaging system. It would be great to define a transport binding for CloudEvents on how to map between pulsar messages and CloudEvents. *Changes* This PR proposes an [Apache Pulsar](https://pulsar.incubator.apache.org/) transport binding for CloudEvents, similar to other existing transport bindings. Signed-off-by: Sijie Guo <sijie@apache.org> Wrap the text at 80 columns add quotes around the names
24477af to
9b0304e
Compare
|
gotcha. thank you @duglin |
Signed-off-by: Sijie Guo <sijie@apache.org>
507df7e to
d60dc69
Compare
|
Per discussion last week, created this PR #254 Pulsar is using a project-proprietary protocol. The payload mapping really ought to be a Protobuf event format, which would be good to work on with Google. I think it'd be great for Pulsar to define and document how to use CloudEvents with Pulsar inside its own project, but it appears doubtful that there are implementers unrelated to the Pulsar project who would pick up the Pulsar binding spec and implement a clean Pulsar protocol binding for interoperability with others. |
|
@clemensv thank you for your comment. some thoughts regarding Protobuf event format:
Hope my thoughts about protobuf event format make sense here. If I missed something regarding spec, please point them out. Happy to learn more about the spec.
I can't speak for the whole pulsar community or the users of pulsar. but from the use cases I can see, cloud events can be used in following use cases in pulsar:
These are the two usages within Pulsar itself. However I am not sure if we should put them in the transport binding spec. I am open to any suggestions. |
|
@sijie My point is that a transport binding spec for CloudEvents is only useful when it is that there will be multiple and potentially competing efforts that will achieve interoperability by implementing a transport binding for CloudEvents based on that spec. I don't see that being the case here since the protocol is project-proprietary. |
|
@sijie there's some concern that the Pulsar spec doesn't meet the minimum bar we've defined for a new protocol/binding - see: https://github.com/cloudevents/spec/blob/master/primer.md#qualifying-protocols-and-encodings I'd be interested in getting your take on it since this will probably come up on this week's call. |
|
@duglin sorry just saw your messages. the concerns make sense to me. feel free to close it. |
|
ok, we'll wait until next week's call to see if anyone has any objections to closing it |
|
Agreed to close it in the 9/20 call. |
Motivation
Apache Pulsar is a distributed pub/sub messaging system.
It would be great to define a transport binding for CloudEvents on
how to map between pulsar messages and CloudEvents.
Changes
This PR proposes an Apache Pulsar
transport binding for CloudEvents, similar to other existing transport bindings.
Signed-off-by: Sijie Guo sijie@apache.org