Removed eventTypeVersion#256
Merged
Merged
Conversation
duglin
reviewed
Jun 28, 2018
| ### schemaURL | ||
| * Type: `URI` | ||
| * Description: A link to the schema that the `data` attribute adheres to. | ||
| Incompatible changes to the schema SHOULD result in a new schema version. |
Collaborator
There was a problem hiding this comment.
I wonder if we should say "URI" instead of "version" just to keep it more generic and not imply that we're mandating a version string be part of the URI, even though that would be a good idea. What do people think? I'm ok either way- it just jumped out at me.
Collaborator
|
@deissnerk can you include an update to the other docs that reference "eventTypeVersion" in this PR? Otherwise, LGTM |
Collaborator
|
you may need to rebase since this include commits that are not yours |
This solves #142 Signed-off-by: Klaus Deissner <klaus.deissner@sap.com>
Removed the term version from the schemaURL definition. Signed-off-by: Klaus Deissner <klaus.deissner@sap.com>
Collaborator
|
hmmm you're up to 14 commits now :-) |
Contributor
Author
|
@duglin Down to two commits now. git push -f did the trick. |
Collaborator
|
@deissnerk perfect - thanks. |
Collaborator
|
Approved on 7/5 call |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #142
I added a sentence to the definition of schemaURL claiming that incompatible changes to the schema SHOULD result in a new schema version. Please let me know, if you are fine with this.