Simplified/Reduced context property names.#339
Conversation
| * Travis Reeder - [@treeder](https://github.com/banisadr) | ||
| * **PayPal** | ||
| * Vladimir Bacvanski | ||
| * Jem Day - [@JemDay](https://github.com/JemDay) |
There was a problem hiding this comment.
EVERYONE - if you've submitted an issue or PR please feel free to open a PR to add your name to this doc.
| * Type: `Any` | ||
| * Description: The event payload. The payload depends on the eventtype and | ||
| * Description: The event payload. The payload depends on the `type` and | ||
| the schemaURL. It is encoded into a media format |
There was a problem hiding this comment.
if you use back-ticks on "type" then for consistency you should on "schemaURL" on the next line, and "contenttype" - and we should be consistent on the case: e.g. schemaURL vs contenttype
|
Everything LGTM, except for one thing: I would strongly prefer to keep |
NOTED - I think this goes against the consistency theme slightly but is probably a good subject for discussion at the next session (@duglin) |
|
yup - I've love to hear what others think, especially since I'm hoping we can resolve that one issue during the call and approve it. So if you can't make the call and have strong opinions on this point please add them here as comments. |
|
LGTM |
|
@JemDay can you rebase? or do you want me to try it? |
Let me try .... |
|
hmm I think something is funky since i see other people's commits |
|
Approved on the Nov 8 call |
4 participants
Simplified/Reduced context property names.
Closes #323