Skip to content

Specify the media type for proto representations #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duglin merged 2 commits into from
Nov 29, 2018
Merged

Specify the media type for proto representations #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32a679b
Specify the media type for proto representations
rachelmyers Nov 8, 2018
31d76c1
Add `MUST` to media types in proto and json
rachelmyers Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion json-format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ The CloudEvents [JSONSchema](http://json-schema.org) for the spec is located

Each CloudEvents event can be wholly represented as a JSON object.

Such a representation uses the media type `application/cloudevents+json`.
Such a representation MUST use the media type `application/cloudevents+json`.
Copy link
Copy Markdown
Collaborator

@duglin duglin Nov 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this to the PR!


All REQUIRED and all not omitted OPTIONAL attributes in the given event MUST
become members of the JSON object, with the respective JSON object member name
Expand Down
1 change: 1 addition & 0 deletions protobuf-format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ The CloudEvents type system MUST be mapped into the fields of
| Integer | int_value
| Any | Not applicable. Any is the enclosing CloudEventAny message itself

Protocol Buffer representations of CloudEvents MUST use the media type `application/cloudevents+proto`.

## 3. Examples

Expand Down