Skip to content

Extensions follow attribute naming scheme introduced in #321 #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duglin merged 1 commit into from
Mar 21, 2019
Merged

Extensions follow attribute naming scheme introduced in #321 #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/distributed-tracing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ platforms like Prometheus are built.
## Encoding

### In-memory formats
The Distributed Tracing extension uses the key `distributedTracing` for in-memory formats
The Distributed Tracing extension uses the key `distributedtracing` for in-memory formats

### HTTP

Expand Down
2 changes: 1 addition & 1 deletion extensions/sampled-rate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ they impose additional sampling.
## Encoding

### In-memory formats
The Sampling extension uses the key `sampledRate` for in-memory formats.
The Sampling extension uses the key `sampledrate` for in-memory formats.

### Transport bindings
The Sampling extension does not customize any transport binding's storage
Expand Down
10 changes: 5 additions & 5 deletions extensions/sequence.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ by a unique event source.

The `sequence` attribute represents the value of this event's
order in the stream of events. The exact value and meaning of this
attribute is defined by the `sequenceType` attribute.
If the `sequenceType` is missing, or not defined in this specification,
attribute is defined by the `sequencetype` attribute.
If the `sequencetype` is missing, or not defined in this specification,
event consumers will need to have some out-of-band communication with the
event producer to understand how to interpret the value of the attribute.

Expand All @@ -22,7 +22,7 @@ event producer to understand how to interpret the value of the attribute.
* MUST be a non-empty lexicographically-orderable string
* RECOMMENDED as monotonically increasing and contiguous

### sequenceType
### sequencetype
* Type: `String`
* Description: Specifies the semantics of the sequence attribute.
See the [SequenceType Values](#sequencetype-values) section for more
Expand All @@ -33,11 +33,11 @@ event producer to understand how to interpret the value of the attribute.

## SequenceType Values

This specification defines the following values for `sequenceType`.
This specification defines the following values for `sequencetype`.
Additional values MAY be defined by other specifications.

### Integer
If the `sequenceType` is set to `Integer`, the `sequence` attribute has
If the `sequencetype` is set to `Integer`, the `sequence` attribute has
the following semantics:
* The values of `sequence` are string-encoded signed 32-bit Integers.
* The sequence MUST start with a value of `1` and increase by `1` for each
Expand Down