[Subscriptions API] Multiple dialects in the filter object by slinkydeveloper · Pull Request #803 · cloudevents/spec

slinkydeveloper · 2021-04-06T12:43:19Z

This PR modifies the shape of the filter subscription request attribute to an array of filter expressions:

This:

filter:
  exact: ...

Becomes this:

filters:
  - exact: ...

The reason to introduce this change is to improve ergonomics of the filter usage in most use cases, where at the top level the user wants to do an and of several filters. In other words this:

filter:
  all:
    - exact: ...
    - prefix: ...

Can be written as:

filters:
  - exact: ...
  - prefix: ...

It also renames filter to filters, in order to be more consistent with the change itself.

The openapi schema change is going to be introduced in another PR.

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

duglin · 2021-04-08T02:14:45Z

No strong opinion but I do suspect AND will be one of the more popular dialects.

duglin · 2021-04-29T01:30:15Z

rebase needed

duglin · 2021-04-29T01:34:57Z

we'd need to change the schema too, from:

  "filter": { ?
    "[dialect name]": [dialect specific object] ?
  },

to

  "filter": { ?
    "[dialect name]": [dialect specific object] *
  },

right?

slinkydeveloper · 2021-04-29T07:46:29Z

Schema fixed

duglin · 2021-04-29T16:10:47Z

change here too: https://github.com/cloudevents/spec/blob/master/subscriptions-api.md#321-subscription-object

slinkydeveloper · 2021-05-03T08:50:08Z

I've removed the openapi schema change as discussed during the meeting

Renamed filter to filters Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

slinkydeveloper · 2021-05-04T08:01:55Z

After discussing with @clemensv, I've changed this PR completely. I've updated the description of the PR accordingly

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

duglin · 2021-05-20T02:07:22Z

Just a few minor syntax questions, otherwise SGTM

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

duglin · 2021-05-24T18:46:13Z

Approved on the 5/20 call

slinkydeveloper · 2021-05-26T14:02:14Z

I'm going to push the followup change to the openapi spec soon

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

[Subscriptions API] Fix OpenAPI as followup of #803

To improve the usage of the API in the common case, like in cloudevents#803, I'm removing the restriction for `exact, `prefix` and `suffix` filters of only containing exacly one attribute. When multiple attributes are specified, all filter must match, for example, these filters: ```yaml filters: - all: suffix: type: "com.github.push" - all: suffix: subject: "https//github.com/cloudevents/spec" ``` can be written as: ```yaml filters: - suffix: type: "com.github.push" subject: "https//github.com/cloudevents/spec" ``` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

To improve the usage of the API in the common case, like in cloudevents#803, I'm removing the restriction for `exact, `prefix` and `suffix` filters of only containing exacly one attribute. When multiple attributes are specified, all filter must match, for example, these filters: ```yaml filters: - suffix: type: "com.github.push" - suffix: subject: "https//github.com/cloudevents/spec" ``` can be written as: ```yaml filters: - suffix: type: "com.github.push" subject: "https//github.com/cloudevents/spec" ``` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

To improve the usage of the API in the common case, I'm removing the restriction for `exact, `prefix` and `suffix` filters of only containing exacly one attribute. When multiple attributes are specified, all filter must match ( like in [1]), for example, these filters: ```yaml filters: - suffix: type: "com.github.push" - suffix: subject: "https//github.com/cloudevents/spec" ``` can be written as: ```yaml filters: - suffix: type: "com.github.push" subject: "https//github.com/cloudevents/spec" ``` [1]: cloudevents#803 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

To improve the usage of the API in the common case, I'm removing the restriction for `exact`, `prefix` and `suffix` filters of only containing exacly one attribute. When multiple attributes are specified, all filter must match ( like in [1]), for example, these filters: ```yaml filters: - suffix: type: "com.github.push" - suffix: subject: "https//github.com/cloudevents/spec" ``` can be written as: ```yaml filters: - suffix: type: "com.github.push" subject: "https//github.com/cloudevents/spec" ``` [1]: cloudevents#803 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

To improve the usage of the API in the common case, I'm removing the restriction for `exact`, `prefix` and `suffix` filters of only containing exactly one attribute. When multiple attributes are specified, all attributes must match ( like in [1]), for example, these filters: ```yaml filters: - suffix: type: "com.github.push" - suffix: subject: "https//github.com/cloudevents/spec" ``` can be written as: ```yaml filters: - suffix: type: "com.github.push" subject: "https//github.com/cloudevents/spec" ``` [1]: cloudevents#803 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

…efix and suffix filters (#957) * Remove exactly one attribute restriction for exact, prefix and suffix To improve the usage of the API in the common case, I'm removing the restriction for `exact`, `prefix` and `suffix` filters of only containing exactly one attribute. When multiple attributes are specified, all attributes must match ( like in [1]), for example, these filters: ```yaml filters: - suffix: type: "com.github.push" - suffix: subject: "https//github.com/cloudevents/spec" ``` can be written as: ```yaml filters: - suffix: type: "com.github.push" subject: "https//github.com/cloudevents/spec" ``` [1]: #803 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Update subscription open API Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

…efix and suffix filters (cloudevents#957) * Remove exactly one attribute restriction for exact, prefix and suffix To improve the usage of the API in the common case, I'm removing the restriction for `exact`, `prefix` and `suffix` filters of only containing exactly one attribute. When multiple attributes are specified, all attributes must match ( like in [1]), for example, these filters: ```yaml filters: - suffix: type: "com.github.push" - suffix: subject: "https//github.com/cloudevents/spec" ``` can be written as: ```yaml filters: - suffix: type: "com.github.push" subject: "https//github.com/cloudevents/spec" ``` [1]: cloudevents#803 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Update subscription open API Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

duglin reviewed Apr 8, 2021

View reviewed changes

Comment thread subscriptions-api.md Outdated

slinkydeveloper mentioned this pull request Apr 14, 2021

[Experimental] Enhanced Trigger filters via adopting CloudEvent Subscriptions API knative/eventing#5204

Closed

8 tasks

slinkydeveloper changed the title ~~Subscriptions api multiple dialects in the filter object~~ [Subscriptions api] multiple dialects in the filter object Apr 21, 2021

slinkydeveloper changed the title ~~[Subscriptions api] multiple dialects in the filter object~~ [Subscriptions API] Multiple dialects in the filter object Apr 21, 2021

slinkydeveloper force-pushed the subscriptions-api-filter branch from 9b9cd32 to 1172ab8 Compare April 29, 2021 07:46

slinkydeveloper force-pushed the subscriptions-api-filter branch from 1172ab8 to aa0f787 Compare May 3, 2021 08:49

slinkydeveloper mentioned this pull request May 3, 2021

[WIP][Subscriptions API] Refactored OpenAPI Filter schema #822

Closed

Now filter accepts an array of expressions, and it does the and of them

531ca9b

Renamed filter to filters Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

slinkydeveloper force-pushed the subscriptions-api-filter branch from aa0f787 to 531ca9b Compare May 4, 2021 08:01

duglin reviewed May 13, 2021

View reviewed changes

Comment thread subscriptions-api.md Outdated

duglin reviewed May 13, 2021

View reviewed changes

Comment thread subscriptions-api.md Outdated

Nit

d83b576

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Support empty array

1a7ed00

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

duglin merged commit d90d1d7 into cloudevents:master May 24, 2021

slinkydeveloper deleted the subscriptions-api-filter branch May 26, 2021 14:00

slinkydeveloper added a commit to slinkydeveloper/spec that referenced this pull request Jun 1, 2021

Fix OpenAPI as followup of cloudevents#803

19aa07a

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

slinkydeveloper mentioned this pull request Jun 1, 2021

[Subscriptions API] Fix OpenAPI as followup of #803 #826

Merged

duglin pushed a commit that referenced this pull request Jun 9, 2021

Merge pull request #826 from slinkydeveloper/fix-openapi

add3a75

[Subscriptions API] Fix OpenAPI as followup of #803

devguyio mentioned this pull request Feb 8, 2022

Implement new trigger filters experimental feature (SubscriptionsAPI Filters) knative-extensions/eventing-kafka-broker#1879

Closed

pierDipi mentioned this pull request Feb 21, 2022

[Subscription] Remove exactly one attribute restriction for exact, prefix and suffix filters #957

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Subscriptions API] Multiple dialects in the filter object#803

[Subscriptions API] Multiple dialects in the filter object#803
duglin merged 3 commits into
cloudevents:masterfrom
slinkydeveloper:subscriptions-api-filter

slinkydeveloper commented Apr 6, 2021 •

edited

Loading

Uh oh!

Uh oh!

duglin commented Apr 8, 2021

Uh oh!

duglin commented Apr 29, 2021

Uh oh!

duglin commented Apr 29, 2021

Uh oh!

slinkydeveloper commented Apr 29, 2021

Uh oh!

duglin commented Apr 29, 2021

Uh oh!

slinkydeveloper commented May 3, 2021

Uh oh!

slinkydeveloper commented May 4, 2021

Uh oh!

Uh oh!

Uh oh!

duglin commented May 20, 2021

Uh oh!

duglin commented May 24, 2021

Uh oh!

slinkydeveloper commented May 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

slinkydeveloper commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

duglin commented Apr 8, 2021

Uh oh!

duglin commented Apr 29, 2021

Uh oh!

duglin commented Apr 29, 2021

Uh oh!

slinkydeveloper commented Apr 29, 2021

Uh oh!

duglin commented Apr 29, 2021

Uh oh!

slinkydeveloper commented May 3, 2021

Uh oh!

slinkydeveloper commented May 4, 2021

Uh oh!

Uh oh!

Uh oh!

duglin commented May 20, 2021

Uh oh!

duglin commented May 24, 2021

Uh oh!

slinkydeveloper commented May 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

slinkydeveloper commented Apr 6, 2021 •

edited

Loading