fix: pass abortSignal to streamText to enable stop streaming#141
Merged
threepointone merged 2 commits intocloudflare:mainfrom Jan 24, 2026
Merged
fix: pass abortSignal to streamText to enable stop streaming#141threepointone merged 2 commits intocloudflare:mainfrom
threepointone merged 2 commits intocloudflare:mainfrom
Conversation
Contributor
|
I don't understand, how does this fix it? options.abortSignal is still not being passed |
Jerrynh770
changed the title
Contributor
Author
Sorry dude, I got a little tired and forgot to push the commit. It’s fixed now. |
Contributor
|
very nice, thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stop streaming button was not working because the abortSignal
received in onChatMessage was not being passed to streamText.