keepAlive: replace schedule rows with ref-counted alarms#1147
Merged
Conversation
Replace the schedule-based keepAlive heartbeat with an in-memory reference-counted alarm. keepAlive() now increments/decrements _keepAliveRefs and relies on _scheduleNextAlarm() to set a single Durable Object alarm every 30s while refs > 0; it no longer creates schedule rows or emits schedule observability events. Add _onAlarmHousekeeping() hook (called on each alarm) for extensions (e.g. fiber mixin) to run recovery/housekeeping. Bump internal schema to v2 and migrate by removing orphaned _cf_keepAliveHeartbeat schedule rows. Remove legacy heartbeat cleanup code, unmark keepAlive/keepAliveWhile as experimental, and update docs and tests to reflect the new behavior. A changeset was added to describe the patch.
🦋 Changeset detectedLatest commit: 8993bee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keepAlive()— no longer creates schedule rows or emitsschedule:create/schedule:execute/schedule:cancelevents every 30 seconds. Uses an in-memory ref count that feeds directly into_scheduleNextAlarm().keepAlive()callers share a single alarm cycle instead of each creating their own interval schedule row (N fibers → 1 alarm, not N schedule rows)._onAlarmHousekeeping()hook called on every alarm cycle, replacing the old_cf_keepAliveHeartbeatcallback. The fiber mixin overrides this for eviction recovery instead of coupling to the scheduling system._cf_keepAliveHeartbeatschedule rows from the previous implementation (without this, upgrading users would hit a tight alarm loop from stale rows).@experimentalfromkeepAlive()andkeepAliveWhile().Test plan
npm run checkpasses (lint, typecheck, format, export validation)docs/scheduling.md,design/think.md)Made with Cursor